Scalability: Improve scaling of service instances #4162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
richard-cox
commented
Mar 12, 2020
•
richard-cox
commented
- Reduce size of request to fetch SIs by removing SB --> App relation
- Fix invalid SI --> S relation. This was causing 2 action dispatches per SI as the missing entity was populated by validation (SI-->S isn't valid in CF API, we had S from elsewhere so validation process associated with SI. We should have been using SI --> SP --> S instead)
- Fix check for additional bindings to SI to be deleted in delete app stepper
- Add some action builder interfaces
- blocked on Scalability: Improve scaling of users and organisations #4156
- getUser would first attempt to fetch all users via getUsers - getUsers could take a long time due to missing relations (users with more than 50 per role) - getUser wouldn't wait for this to finish and then try and make an individual request to fetch user - this user would then also be validated and missing relations fetched
- Remove org-space-route relation from orgs and org api requests - Ensure we don't fetch entity counts unless we need to
- sometimes errorResponse can be null (for instance timeout)
- Delete SI success handler was incorrectly clearing pagination instead of just removing entity from pagination
- Delete of entity was fine, however it was not removed from list - With bug entity was still not visible in list afterwards only due to nulls filtered out in list
…ce filters have loaded
- Reduce size of request to fetch SIs by removing SB --> App relation - Fix invalid SI --> S relation (this caused 2 action dispatched per SI) - Fix check for additional bindings to SI to be deleted in delete app stepper - Add some action builder interfaces
nwmac
reviewed
Mar 18, 2020
src/frontend/packages/cloud-foundry/src/features/applications/application.service.ts
Outdated
Show resolved
Hide resolved
richard-cox
changed the title
richard-cox
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.