Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple User Provided Service Instance Create/Update Fixes #4117

Merged
merged 1 commit into from
Feb 4, 2020
Merged

Multiple User Provided Service Instance Create/Update Fixes #4117

merged 1 commit into from
Feb 4, 2020

Conversation

richard-cox
Copy link
Contributor

  • On transition from service instance list to edit UPSI stepper user can now supply just tags to enable form
  • Fixed error handling on create/update UPSI flows (user should be able to see errors, and console successfully waits until service create/update completes)
  • Ensure we update service instance list after creating user provided service instance

@richard-cox
Multiple User Provided Service Instance Create/Update Fixes
2ff49c4 
- On transistion from list to edit stepper user can now supply just tags to enable form
- Fixed error handling on create and update flows
- Ensure we update service instance list after creating user provided service instance
@richard-cox richard-cox self-assigned this Feb 3, 2020
nwmac
nwmac approved these changes Feb 4, 2020
View reviewed changes
Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit f96f8c7 into master Feb 4, 2020
@nwmac nwmac deleted the upsi-fixes branch February 4, 2020 11:32
@richard-cox richard-cox modified the milestone: 3.1.0 Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwmac nwmac nwmac approved these changes

Assignees

@richard-cox richard-cox

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richard-cox @nwmac