Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cf validation fix following v3 changes #4080

Merged
merged 4 commits into from
Jan 8, 2020
Merged

Cf validation fix following v3 changes #4080

merged 4 commits into from
Jan 8, 2020

Conversation

richard-cox
Copy link
Contributor

  • Fix issue where we weren't normalizing the response to entities that were fetched via validation following the v3 changes
  • Tested via fetching empty application on home screen, going to application summary and checking that the app's space entity contained a normalised org (so just guid instead of entire org entity)
    home-page.component.ts ctor 
        const a = this.entityServiceFactory.create<APIResource<IApp>>(
    'cf9e525e-59d1-41c4-a181-db7e6be7eed3',
    new GetApplication('cf9e525e-59d1-41c4-a181-db7e6be7eed3', 'yoUDQeX3D7YJXlRDSXnqqmO-d6M')
  );
  a.waitForEntity$.subscribe();
  • Also fixed/harmonised the favourite cards
    • Don't show duplicate space name on space card
    • Show created date on org and space cards as per app card

@richard-cox
Fix issue where clicking on org and then app fav failed
829e160 
    - Issue 1 (slightly unrelated)
      - app service getspace action used space schema without an org
    - Issue 2
      - app entity validation found it was missing the space
      - validation process fetched space with custom action
      - custom action did not contain schema key linked to space schema with org
      - this lead to org being not stored correctly in store (contained in space rather than seperatly)
      - Simple fix (see 0a16203284c for harder)
         - When normalizing prioritise the action's schema over attempting
           to fetch via entity catalogue + schemaKey
           (avoids A LOT of plumbing)
@richard-cox
Favourites - Remove duplicated space name, add creation to space + org
cc05641
@richard-cox richard-cox self-assigned this Jan 7, 2020
@richard-cox richard-cox changed the title Port cf validation fix following v3 changes Cf validation fix following v3 changes Jan 7, 2020
@codecov-io
Copy link

Codecov Report

Merging #4080 into master will increase coverage by 0.02%.
The diff coverage is 8.69%.

@@            Coverage Diff             @@
##           master    #4080      +/-   ##
==========================================
+ Coverage   57.69%   57.71%   +0.02%     
==========================================
  Files         887      886       -1     
  Lines       28543    28541       -2     
  Branches     4032     4034       +2     
==========================================
+ Hits        16467    16472       +5     
+ Misses      12076    12069       -7

nwmac
nwmac suggested changes Jan 8, 2020
View reviewed changes
Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of questions

@nwmac nwmac added the needs attention This PR needs attention label Jan 8, 2020
@richard-cox richard-cox added comments-addressed and removed needs attention This PR needs attention labels Jan 8, 2020
@nwmac nwmac merged commit 7c94858 into master Jan 8, 2020
@nwmac nwmac deleted the fix-validation branch January 8, 2020 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwmac nwmac nwmac approved these changes

Assignees

@richard-cox richard-cox

Labels
comments-addressed ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@richard-cox @codecov-io @nwmac