Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blitz - Deploy applications using docker image #4069

Merged
merged 9 commits into from
Jan 8, 2020
Merged

Blitz - Deploy applications using docker image #4069

merged 9 commits into from
Jan 8, 2020

Conversation

richard-cox
Copy link
Contributor

@richard-cox richard-cox commented Dec 20, 2019

TODO:

  • UX Review

@richard-cox richard-cox changed the title Deploy applications using docker image Blitz - Deploy applications using docker image Dec 20, 2019
Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UX suggestions:

  • On the overrides stepper, hide the application name and the docker settings at the bottom, since you can't override these in this case and you've all ready specified these on the previous step
  • On the Source stepper, change the text to say "Please specify an application and and the docker image to be used (registry/org/image-name).

@nwmac nwmac added the needs attention This PR needs attention label Jan 8, 2020
@richard-cox richard-cox added comments-addressed and removed needs attention This PR needs attention labels Jan 8, 2020
@nwmac nwmac merged commit ea3778a into master Jan 8, 2020
@nwmac nwmac deleted the blitz-docker branch January 8, 2020 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploy application via docker image
2 participants