Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blitz - User Service & Deploy from git fixes #4062

Merged
merged 4 commits into from
Dec 13, 2019
Merged

Conversation

richard-cox
Copy link
Contributor

Fix user service

  • At cf level we were fetching users from all cf's not just the one we were viewing (ensure action builder constructors are correct)
  • removed duplicate cf-user-service

Fix super sluggish behaviour when deploying from git …

  • most of the git actions included the scm object
  • scm objects included httpClient
  • this lead to very large actions being dispatched
  • fix is to supply httpClient when needed

- ensure action builder constructors are correct (were fetching users for all endpoints instead of contextual one)
- removed duplicate cf-user-service
- most of the git actions included the scm object
- scm objects included httpClient
- this lead to very large actions being dispatched
- fix is to supply httpClient when needed
Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit d9e7fc5 into master Dec 13, 2019
@nwmac nwmac deleted the blitz-minor-fixes branch December 13, 2019 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants