Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for setup UI for local admin account #4031

Merged
merged 12 commits into from
Jan 7, 2020
Merged

Add support for setup UI for local admin account #4031

merged 12 commits into from
Jan 7, 2020

Conversation

nwmac
Copy link
Contributor

@nwmac nwmac commented Nov 29, 2019

No description provided.

@nwmac nwmac self-assigned this Nov 29, 2019
nwmac
nwmac commented Dec 3, 2019
View reviewed changes
...tend/packages/core/src/features/setup/local-account-wizard/local-account-wizard.component.ts Outdated
};

this.applyingSetup$.next(true);
this.store.dispatch(new SetupUAASave(data));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull out common code

nwmac
nwmac commented Dec 3, 2019
View reviewed changes
src/frontend/packages/store/src/effects/uaa-setup.effects.ts
params
const params = this.getParams(setupData);
return this.http.post(this.uaaSetupUrl, params, {
headers: { 'Content-Type': 'application/x-www-form-urlencoded' },
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try without this header but with plain object for params

@nwmac nwmac added the needs attention This PR needs attention label Dec 3, 2019
nwmac
nwmac commented Dec 3, 2019
View reviewed changes
src/jetstream/main.go Outdated Show resolved Hide resolved
nwmac
nwmac commented Dec 3, 2019
View reviewed changes
src/jetstream/setup_console.go Outdated Show resolved Hide resolved
nwmac
nwmac commented Dec 3, 2019
View reviewed changes
src/jetstream/setup_console.go Outdated Show resolved Hide resolved
@nwmac nwmac added comments-addressed and removed needs attention This PR needs attention labels Jan 6, 2020
@richard-cox richard-cox added the conflicts Merge conflicts on PR label Jan 6, 2020
@nwmac nwmac removed comments-addressed conflicts Merge conflicts on PR labels Jan 6, 2020
@richard-cox richard-cox self-requested a review January 7, 2020 11:19
nwmac and others added 2 commits January 7, 2020 11:59
@nwmac
Fix unit tests
56089ed
@richard-cox
Fix setup via uaa and error handling
abc93ca 
- Fix background of error popup (ensure theme is initialised)
- Fix setup via uaa (incorrect url)
- Ensure error message in popup is shown (use new http error response object)
richard-cox
richard-cox approved these changes Jan 7, 2020
View reviewed changes
Copy link
Contributor

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nwmac LGTM, might be worth you reviewing my commit though

@nwmac nwmac merged commit ef67eb5 into master Jan 7, 2020
@nwmac nwmac deleted the setup-ui-local-auth branch January 7, 2020 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richard-cox richard-cox richard-cox approved these changes

Assignees

@nwmac nwmac

Labels
in review ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nwmac @richard-cox