Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure active dialog times out correctly #4026

Merged
merged 1 commit into from
Dec 3, 2019
Merged

Ensure active dialog times out correctly #4026

merged 1 commit into from
Dec 3, 2019

Conversation

richard-cox
Copy link
Contributor

@richard-cox richard-cox commented Nov 28, 2019 •
edited
Loading

  • previously..
    • time out duration was checked every tick of interval
    • this slows down when tab is not active, leading to situation when session was inactive but time out counter was still ticking. Clickin 'yes' then lead to log out
  • now..
    • tick as before but check timeout via date every time
  • also..
    • added some code on the way that wasn't needed, but may be in the future
    • will delete later if not used

@richard-cox
Ensure active dialog times out correctly
71ba470 
- previously.. time out duration was checked every tick of `interval`
  - this slows down when tab is not active, leading to situation when session was inactive but time out counter was still ticking. Clickin 'yes' then lead to log out
- now..
  - tick as before but check timeout via date every time
- also..
  - added some code on the way that wasn't needed, but may be in the future
  - will delete later if not used
@richard-cox richard-cox self-assigned this Nov 28, 2019
@richard-cox richard-cox mentioned this pull request Nov 28, 2019
Merged
nwmac
nwmac approved these changes Dec 3, 2019
View reviewed changes
Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit a9ebc28 into master Dec 3, 2019
@nwmac nwmac deleted the fix-timeout-dialog-timer branch December 3, 2019 10:03
@richard-cox richard-cox mentioned this pull request Apr 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwmac nwmac nwmac approved these changes

Assignees

@richard-cox richard-cox

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richard-cox @nwmac