Update metric used for cells #4009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `firehose_value_metric_rep_unhealthy_cell` deprecated, now use `firehose_value_metric_rep_garden_health_check_failed` - Try new metric first and fall back on old
Codecov Report
@@ Coverage Diff @@
## v2-master #4009 +/- ##
=============================================
- Coverage 52.23% 52.19% -0.04%
=============================================
Files 785 786 +1
Lines 23025 23050 +25
Branches 4124 4128 +4
=============================================
+ Hits 12027 12032 +5
- Misses 10998 11018 +20 |
nwmac
pushed a commit
that referenced
this pull request
Dec 4, 2019
* Follow redirect - needed for repo move * Update metric used for cells (#4009) - `firehose_value_metric_rep_unhealthy_cell` deprecated, now use `firehose_value_metric_rep_garden_health_check_failed` - Try new metric first and fall back on old * Fix incorrect SSO behaviour following 2.4.0 --> 2.6.0 upgrade (#4015) - affects db migration of console config table to new config table - fixes #4013 * 2.6.1 Release preparation * Ingress fix (#4024) * Fixes ingress and kube 1.16 version issue * Update Changelog * More test * Fix ingress tests * Mention STRATOS_BP_DEBUG to troubleshoot staging (#4039) * Fix following merge
nwmac
added a commit
that referenced
this pull request
Jan 6, 2020
* Follow redirect - needed for repo move * Update metric used for cells (#4009) - `firehose_value_metric_rep_unhealthy_cell` deprecated, now use `firehose_value_metric_rep_garden_health_check_failed` - Try new metric first and fall back on old * Fix incorrect SSO behaviour following 2.4.0 --> 2.6.0 upgrade (#4015) - affects db migration of console config table to new config table - fixes #4013 * 2.6.1 Release preparation * Ingress fix (#4024) * Fixes ingress and kube 1.16 version issue * Update Changelog * More test * Fix ingress tests * Show more service instance last operation details * Show service instance service broker * Handle last operation & broker in table view * Show the service broker name in the service list service card * Mention STRATOS_BP_DEBUG to troubleshoot staging (#4039) * Backend changs to support long-running requests * Fix create service instance from service instance page * Fix unit tests * Ensure service plans are sorted by display name - sometimes these are fetched inline which aren't sorted * Fix helm chart issue with semver (#4046) * Handle Long Running Service Instance Operations - Some brokers take a long time to execute create, update and delete service instance operations - This time exceeded the amount allowed by browser/jetstream - We now provide a custom response to the front end when this happens - Front end then handles this and also shows a custom error message * Fixes post merge * Changes and tidy up post review - Use a common way to get a service name, service link, broker name - Split out cf specific long running functionality - Show service as a link in app service instance card - Show service plan and broker in app service instance card - Update the service instance entity on Update as well as Delete (will show a better 'last operation' value) * Fixes post merge * Fix failing unit tests * Improvements to error/notification process - Show mini error message, as per create, when updating service instance - Handle all 5XX status codes as errors - Update messages to reflect varience of error states - Show single popover message on error dismiss all button - Correct error page selector * Treat calls to multiple endpoints as `global` - calls where we generate the endpoint lists (app wall, etc) were handled badly by jetstreamErrorHandler - this was due to the internal event storing endpoint id as `` instead of one per endpoint - this happened due to the list of generated endpoints being applied directly to request object in lower function - treat these as global for the moment * More fixes * Fix failing e2e test * Show last operation and service broker info for service instances (#4038) * Show more service instance last operation details * Show service instance service broker * Handle last operation & broker in table view * Show the service broker name in the service list service card * Fix create service instance from service instance page * Fix unit tests * Fix failing e2e test * Fix bad merge * Fix failing tests Co-authored-by: Neil MacDougall <nwmac@users.noreply.github.com> Co-authored-by: Guillaume Berche <guillaume.berche@orange.com>
nwmac
added a commit
that referenced
this pull request
Jan 7, 2020
* Follow redirect - needed for repo move * Update metric used for cells (#4009) - `firehose_value_metric_rep_unhealthy_cell` deprecated, now use `firehose_value_metric_rep_garden_health_check_failed` - Try new metric first and fall back on old * Fix incorrect SSO behaviour following 2.4.0 --> 2.6.0 upgrade (#4015) - affects db migration of console config table to new config table - fixes #4013 * 2.6.1 Release preparation * Ingress fix (#4024) * Fixes ingress and kube 1.16 version issue * Update Changelog * More test * Fix ingress tests * Show more service instance last operation details * Show service instance service broker * Handle last operation & broker in table view * Show the service broker name in the service list service card * Mention STRATOS_BP_DEBUG to troubleshoot staging (#4039) * Backend changs to support long-running requests * Fix create service instance from service instance page * Fix unit tests * Ensure service plans are sorted by display name - sometimes these are fetched inline which aren't sorted * Fix helm chart issue with semver (#4046) * Handle Long Running Service Instance Operations - Some brokers take a long time to execute create, update and delete service instance operations - This time exceeded the amount allowed by browser/jetstream - We now provide a custom response to the front end when this happens - Front end then handles this and also shows a custom error message * Fixes post merge * Changes and tidy up post review - Use a common way to get a service name, service link, broker name - Split out cf specific long running functionality - Show service as a link in app service instance card - Show service plan and broker in app service instance card - Update the service instance entity on Update as well as Delete (will show a better 'last operation' value) * Fixes post merge * Fix failing unit tests * Improvements to error/notification process - Show mini error message, as per create, when updating service instance - Handle all 5XX status codes as errors - Update messages to reflect varience of error states - Show single popover message on error dismiss all button - Correct error page selector * Treat calls to multiple endpoints as `global` - calls where we generate the endpoint lists (app wall, etc) were handled badly by jetstreamErrorHandler - this was due to the internal event storing endpoint id as `` instead of one per endpoint - this happened due to the list of generated endpoints being applied directly to request object in lower function - treat these as global for the moment * More fixes * Fix failing e2e test * Add table view to marketplace service table * Show last operation and service broker info for service instances (#4038) * Show more service instance last operation details * Show service instance service broker * Handle last operation & broker in table view * Show the service broker name in the service list service card * Fix create service instance from service instance page * Fix unit tests * Fix failing e2e test * Fix unit tests * Fix bad merge * Fix unit tests * Fix e2e tests * Fix removal of `cf` column when there's only one connected cf Co-authored-by: Neil MacDougall <nwmac@users.noreply.github.com> Co-authored-by: Guillaume Berche <guillaume.berche@orange.com>
nwmac
added a commit
that referenced
this pull request
Jan 24, 2020
* Follow redirect - needed for repo move * Update metric used for cells (#4009) - `firehose_value_metric_rep_unhealthy_cell` deprecated, now use `firehose_value_metric_rep_garden_health_check_failed` - Try new metric first and fall back on old * Fix incorrect SSO behaviour following 2.4.0 --> 2.6.0 upgrade (#4015) - affects db migration of console config table to new config table - fixes #4013 * 2.6.1 Release preparation * Ingress fix (#4024) * Fixes ingress and kube 1.16 version issue * Update Changelog * More test * Fix ingress tests * Mention STRATOS_BP_DEBUG to troubleshoot staging (#4039) * Backend changs to support long-running requests * Fix helm chart issue with semver (#4046) * Show last operation and service broker info for service instances (#4038) * Show more service instance last operation details * Show service instance service broker * Handle last operation & broker in table view * Show the service broker name in the service list service card * Fix create service instance from service instance page * Fix unit tests * Fix failing e2e test * Fix chrome driver version (#4078) * Fix long running service actions (#4049) * Show more service instance last operation details * Show service instance service broker * Handle last operation & broker in table view * Show the service broker name in the service list service card * Fix create service instance from service instance page * Fix unit tests * Ensure service plans are sorted by display name - sometimes these are fetched inline which aren't sorted * Handle Long Running Service Instance Operations - Some brokers take a long time to execute create, update and delete service instance operations - This time exceeded the amount allowed by browser/jetstream - We now provide a custom response to the front end when this happens - Front end then handles this and also shows a custom error message * Changes and tidy up post review - Use a common way to get a service name, service link, broker name - Split out cf specific long running functionality - Show service as a link in app service instance card - Show service plan and broker in app service instance card - Update the service instance entity on Update as well as Delete (will show a better 'last operation' value) * Fix failing unit tests * Fix failing e2e test * Fix bad merge * Fixes following merge * Fix table cell active/bindable icons * Remove incorrectly merged file * Fix message for long running delete service instance * Fix service market place list bug where user provided services didn't show * Remove dupe file Co-authored-by: Neil MacDougall <nwmac@users.noreply.github.com> Co-authored-by: Guillaume Berche <guillaume.berche@orange.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
firehose_value_metric_rep_unhealthy_celldeprecated, now usefirehose_value_metric_rep_garden_health_check_failed