Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm Chart: Numerous improvements #4000

Closed
wants to merge 17 commits into from
Closed

Helm Chart: Numerous improvements #4000

wants to merge 17 commits into from

Conversation

nwmac
Copy link
Contributor

@nwmac nwmac commented Oct 30, 2019 •
edited
Loading

  • Remove need for post flight job = simplify db migration = perform migration in backend startup consistently and use the MariaDB container to create the database + user that we need
  • Remove upgrade volume
  • Preparation for removing encryption volume
  • Support external database
  • Tidy up of secrets
  • Database config tidy up

Fixes: #1416, #3506, #3499

@nwmac nwmac self-assigned this Oct 30, 2019
@nwmac nwmac changed the base branch from v2-master to master October 30, 2019 15:23
@codecov-io
Copy link

codecov-io commented Nov 6, 2019 •
edited
Loading

Codecov Report

Merging #4000 into master will decrease coverage by 0.03%.
The diff coverage is 59.32%.

@@            Coverage Diff            @@
##           master   #4000      +/-   ##
=========================================
- Coverage   57.93%   57.9%   -0.04%     
=========================================
  Files         899     902       +3     
  Lines       28842   28909      +67     
  Branches     4083    4086       +3     
=========================================
+ Hits        16709   16739      +30     
- Misses      12133   12170      +37

@nwmac nwmac added the on hold This PR isn't finished and isn't actively being worked on, but will be in the near future. label Dec 3, 2019
@nwmac
Copy link
Contributor Author

nwmac commented Feb 18, 2020

Closing - addressed in newer PR

@nwmac nwmac closed this Feb 18, 2020
@nwmac nwmac deleted the db-tidy-up branch October 16, 2020 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nwmac nwmac

Labels
in progress on hold This PR isn't finished and isn't actively being worked on, but will be in the near future.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Helm Chart: Randomize passwords
2 participants
@nwmac @codecov-io