Add endpoint error page #3991
Add endpoint error page #3991
Conversation
* master: Master test fixes (#3992) Fix npm audit error in dev dependency - handlebars used by istanbul & karma-coverage-istanbul-reporter - weird goings on in stratos (npm audit shows handlebars errors), vanilla angular 7 app (shows no handlebars errors) and vanilla angular 8 app (no handlabrs errors). Same istanbul and coverage dependencies in all node_modules directories and same coverage dependency in all apps - In the end fixed via audit's recommendation to `npm update handlebars --depth 4` Update versions links in readme Fix v2-master references and goreportcard link
There was a problem hiding this comment.
- It would be really useful for the user to remove the red bar. Either hide it until another error comes in or clear all previous errors. If there are errors that haven't been cleared the bell icon could show a notification that would take user to errors page
- Mentioned in comments, but it would be good to have the errors list as a list with all the sorting and filtering goodness and avoids sizeable white space areas. This could also show all errors and filter by endpoint
- Endpoint errors should be cleared on disconnect, particularly for the case where the next user to connect is different from previous one
- Warning bar shows on stepper components where we already have a notification on error. As its more noticeable now not sure if we should hide it?
...re/src/shared/components/list/list-types/endpoint/endpoint-card/endpoint-card.component.html
Outdated
Show resolved
Hide resolved
src/frontend/packages/core/src/features/error-page/error-page/error-page.component.html
Outdated
Show resolved
Hide resolved
src/frontend/packages/core/src/features/error-page/error-page/error-page.component.html
Outdated
Show resolved
Hide resolved
src/frontend/packages/core/src/features/error-page/error-page/error-page.component.html
Show resolved
Hide resolved
src/frontend/packages/core/src/features/error-page/error-page/error-page.component.html
Show resolved
Hide resolved
That's the plan but out of scope for this ticket.
I intentionally didn't use the list to keep it simple. As is a time sorted list, I prefer the one item per row, it makes it easier to understand and makes it less cluttered.
Out of scope #2974.
Maybe. If it was there before I'd err on the side of keeping it as it is for now. |
|
@richard-cox I had an overnight epiphany and decided to fix the "Out of scope" issues. It was just a PITA without them. I'm almost done with them. |
* master: Add clean routes to e2e-clean-remnants (#4007) Auth jetstream refactor (#3882) Remove page nav not needed Local user account docs (#3952) Fix go mod files (#3986) Update references following graduation Ensure build cache upload fail does not fail job (#3994) Fixes issue properly Preparation for 2.6.0 Release Fix alignment of user button on newer Firefox Fix cert gen on Mac OSX 10.15
Codecov Report
@@ Coverage Diff @@
## master #3991 +/- ##
=========================================
- Coverage 61.12% 61.1% -0.03%
=========================================
Files 860 861 +1
Lines 29359 29422 +63
Branches 4294 4307 +13
=========================================
+ Hits 17945 17977 +32
- Misses 11414 11445 +31 |
Add a view to see the recent errors for a given endpoint.
Add a link to the "red bar" that sends the user recent error page for a single endpoint.
Improved the look of the red bar (more inline with material design).
Add a link to the error page to download the error information as a json file.