Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix alignment of user button on newer Firefox #3983

Merged
merged 2 commits into from
Oct 15, 2019
Merged

Fix alignment of user button on newer Firefox #3983

merged 2 commits into from
Oct 15, 2019

Conversation

nwmac
Copy link
Contributor

@nwmac nwmac commented Oct 14, 2019

No description provided.

@nwmac nwmac self-assigned this Oct 14, 2019
@cfdreddbot
Copy link

✅ Hey nwmac! The commit authors and yourself have already signed the CLA.

richard-cox
richard-cox suggested changes Oct 14, 2019
View reviewed changes
Copy link
Contributor

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This causes some drooping in chrome & old FF

image

image

@richard-cox richard-cox added needs attention This PR needs attention and removed ready for review labels Oct 14, 2019
@nwmac nwmac added comments-addressed and removed needs attention This PR needs attention labels Oct 14, 2019
@richard-cox richard-cox merged commit 8baa937 into v2-master Oct 15, 2019
@richard-cox richard-cox deleted the firefox-fix branch October 15, 2019 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richard-cox richard-cox richard-cox approved these changes

Assignees

@nwmac nwmac

Labels
comments-addressed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nwmac @cfdreddbot @richard-cox