Angular 8 Migration #3950
Merged
Angular 8 Migration #3950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KlapTrap
added
in progress
dependencies
|
✅ Hey KlapTrap! The commit authors and yourself have already signed the CLA. |
KlapTrap
added
on hold
* master: (33 commits) Master test fixes (#3992) Fix npm audit error in dev dependency - handlebars used by istanbul & karma-coverage-istanbul-reporter - weird goings on in stratos (npm audit shows handlebars errors), vanilla angular 7 app (shows no handlebars errors) and vanilla angular 8 app (no handlabrs errors). Same istanbul and coverage dependencies in all node_modules directories and same coverage dependency in all apps - In the end fixed via audit's recommendation to `npm update handlebars --depth 4` Some unit test fixes Update versions links in readme Fix v2-master references and goreportcard link Trivial change Address some todo's, make issues for others Remove unused route Fix unit test Reverted the app wall and removed console.log Fix lint & unit tests Fix connect to endpoint subtype Ensure we're passing the correct params to action builders. Removed console logs Ensure endpoint register tiles are ordered correctly Start with empty CustomizationsMetadata Convert CustomizationsMetadata inject into singleton CustomizationService Fix npm audit vulnerabilities (#3899) Remove old ingress docs and add new (#3961) Helm Chart: Add ingress support (#3935) ...
KlapTrap
added
in progress
and removed
on hold
|
fixes #3950 |
* master: (38 commits) CC fixes When viewing enpoint events, provide an endpoint only events view. Change error time period to 30 minutes Fixed exception Minor endpoint page changes Update events page slightly Fix app summay page warning for autoscaler check Fix unit tests Tidy up Finish wiring in of notification bar to errors, fix issue with multiple triggered events for same config Only show bell when there's notifications (whether read or unread) Allow notifications to be marked as 'read' - read notifications will not be shown in the alarm bell count WIP Add clean routes to e2e-clean-remnants (#4007) Tie in error state to notifications Allow notifications to be marked as 'read' - read notifications will not be shown in the alarm bell count Fix unit tests Fix exception on endpoint errors Linting Auth jetstream refactor (#3882) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's mostly done but we have a lot of RequestOptions in our api actions. The api pipelines accept use the httpclient HttpRequest object so it's a matter of replacing RequestOptions with HttpRequest and the rest should take care of itself.
There are a few other, non RequestOptions errors but not too many.