Helm Chart: Add ingress support #3935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Hey nwmac! The commit authors and yourself have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #3935 +/- ##
=============================================
+ Coverage 52.21% 52.22% +<.01%
=============================================
Files 785 785
Lines 23017 23017
Branches 4124 4124
=============================================
+ Hits 12019 12020 +1
+ Misses 10998 10997 -1 |
kreinecke
approved these changes
Oct 4, 2019
KlapTrap
added a commit
that referenced
this pull request
Oct 9, 2019
* v3-master: Fix lint & unit tests Fix connect to endpoint subtype Ensure we're passing the correct params to action builders. Removed console logs Ensure endpoint register tiles are ordered correctly Start with empty CustomizationsMetadata Convert CustomizationsMetadata inject into singleton CustomizationService Fix npm audit vulnerabilities (#3899) Remove old ingress docs and add new (#3961) Helm Chart: Add ingress support (#3935) Fix liniting unit tests: added more tests for components and utils Merge pull request #3939 from cloudfoundry-incubator/mysqldb-dev Gate SSO redirect on optional state whitelist (#3933) Add debug info for manage users e2e tests (#3938) Fix metrics issue with multiple k8s endpoints Fix non jetstream requests and other, minor fixes.
KlapTrap
added a commit
that referenced
this pull request
Oct 17, 2019
* master: (33 commits) Master test fixes (#3992) Fix npm audit error in dev dependency - handlebars used by istanbul & karma-coverage-istanbul-reporter - weird goings on in stratos (npm audit shows handlebars errors), vanilla angular 7 app (shows no handlebars errors) and vanilla angular 8 app (no handlabrs errors). Same istanbul and coverage dependencies in all node_modules directories and same coverage dependency in all apps - In the end fixed via audit's recommendation to `npm update handlebars --depth 4` Some unit test fixes Update versions links in readme Fix v2-master references and goreportcard link Trivial change Address some todo's, make issues for others Remove unused route Fix unit test Reverted the app wall and removed console.log Fix lint & unit tests Fix connect to endpoint subtype Ensure we're passing the correct params to action builders. Removed console logs Ensure endpoint register tiles are ordered correctly Start with empty CustomizationsMetadata Convert CustomizationsMetadata inject into singleton CustomizationService Fix npm audit vulnerabilities (#3899) Remove old ingress docs and add new (#3961) Helm Chart: Add ingress support (#3935) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3570
I've tested this on a local test system