-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gate SSO redirect on optional state whitelist #3933
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Hey richard-cox! The commit authors and yourself have already signed the CLA. |
nwmac
suggested changes
Sep 27, 2019
richard-cox
added
ready for review
and removed
in progress
needs attention
This PR needs attention
labels
Oct 1, 2019
Codecov Report
@@ Coverage Diff @@
## v2-master #3933 +/- ##
==========================================
Coverage 52.21% 52.21%
==========================================
Files 785 785
Lines 23017 23017
Branches 4124 4124
==========================================
Hits 12019 12019
Misses 10998 10998 |
nwmac
approved these changes
Oct 3, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
KlapTrap
added a commit
that referenced
this pull request
Oct 9, 2019
* v3-master: Fix lint & unit tests Fix connect to endpoint subtype Ensure we're passing the correct params to action builders. Removed console logs Ensure endpoint register tiles are ordered correctly Start with empty CustomizationsMetadata Convert CustomizationsMetadata inject into singleton CustomizationService Fix npm audit vulnerabilities (#3899) Remove old ingress docs and add new (#3961) Helm Chart: Add ingress support (#3935) Fix liniting unit tests: added more tests for components and utils Merge pull request #3939 from cloudfoundry-incubator/mysqldb-dev Gate SSO redirect on optional state whitelist (#3933) Add debug info for manage users e2e tests (#3938) Fix metrics issue with multiple k8s endpoints Fix non jetstream requests and other, minor fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSO_WHITELIST
env varSSO_WHITELIST
is a comma separated list which must contain thestate
redirect, otherwise return 401