Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix two autoscaler bugs #3886

Merged
merged 2 commits into from
Sep 19, 2019
Merged

Fix two autoscaler bugs #3886

merged 2 commits into from
Sep 19, 2019

Conversation

richard-cox
Copy link
Contributor

@richard-cox
Fix edit of just created policy
cd185cf 
- create/update used 'update' action
- this caused the initial '404 not found' error to never be cleared after policy created
- now correctly use different actions for create/update
@richard-cox
Fix sub leak
4c4dda8 
- fixes #3881
@richard-cox richard-cox self-assigned this Sep 19, 2019
@cfdreddbot
Copy link

✅ Hey richard-cox! The commit authors and yourself have already signed the CLA.

@codecov
Copy link

codecov bot commented Sep 19, 2019

Codecov Report

Merging #3886 into v2-master will increase coverage by <.01%.
The diff coverage is 65.9%.

@@              Coverage Diff              @@
##           v2-master    #3886      +/-   ##
=============================================
+ Coverage      52.21%   52.22%   +<.01%     
=============================================
  Files            785      785              
  Lines          22975    22998      +23     
  Branches        4116     4122       +6     
=============================================
+ Hits           11997    12011      +14     
- Misses         10978    10987       +9

nwmac
nwmac approved these changes Sep 19, 2019
View reviewed changes
Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit 092125a into v2-master Sep 19, 2019
@nwmac nwmac deleted the fix-autoscaler branch September 19, 2019 13:48
KlapTrap added a commit that referenced this pull request Sep 20, 2019
@KlapTrap
Merge branch 'v2-master' into v3-master
7c6e7fd 
* v2-master:
  Fix several service related bugs, some related to space scoped services (#3879)
  Fix two autoscaler bugs (#3886)
  spaces: fixed deletion in summary subheader
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwmac nwmac nwmac approved these changes

Assignees

@richard-cox richard-cox

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix sub leak in new autoscaler code
3 participants
@richard-cox @cfdreddbot @nwmac