-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for view and edit profile for local user #3883
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Hey nwmac! The commit authors and yourself have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #3883 +/- ##
=============================================
- Coverage 52.22% 52.21% -0.01%
=============================================
Files 785 785
Lines 23010 23017 +7
Branches 4124 4124
=============================================
+ Hits 12016 12019 +3
- Misses 10994 10998 +4 |
richard-cox
approved these changes
Sep 20, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, will merge once passed gates
KlapTrap
added a commit
that referenced
this pull request
Sep 25, 2019
* v3-master: Fix cf summary unit test failures - cf now has dependency on autoscaler - see #3916 catalogue: fixed initial state that was overwritten Travis: Build once and share build in e2e tests (#3901) Improve user clean up Ensure MB is only shown for memory based quota values in edit quota forms (#3892) Fix domains in create app shell stepper Fix git commit world WIP Fix two actionBuilder params issues - Fix three places where `includeRelations` were passed incorrectly to actionBuilder - Fix bind service Ensure multi endpoint requests only go out to connected/unconnectable endpoints - Fixes #3887 Travis: Build once and share build in e2e tests (#3901) Improve user clean up Ensure MB is only shown for memory based quota values in edit quota forms (#3892) Add support for view and edit profile for local user (#3883) Add fix to wait until delete indicator has been removed (#3889) FIx setup detection for local users (#3888) Ensure stepper buttons are always visible and content scrolls (#3890) E2E Test should run as user not admin (#3894)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.