Auth jetstream refactor #3882

kreinecke · 2019-09-18T14:27:09Z

Refactor UAA and Local login auth code.

StratosAuth interface created that provides generic login/logout/verifysession methods.
Separate structs for local and UAA auth implement that interface. External references are to the interface only. Concrete type is instantiated at startup based on the configured remote/local endpoint type.
Global portalProxy struct remains for now but the aim to break this up as more refactoring is done - plugins will then use a collection of interfaces.
Auth code remains at top level until codebase sufficiently decoupled to allow moving down into packages. Interfaces will then be public and structs hidden.
Some utility functions and portalProxy methods with low dependencies moved down into packages where possible.
Echo routing now has auth routes grouped.

Signed-off-by: Kate E. Reinecke <50168367+kreinecke@users.noreply.github.com>

…nd login auth groups Signed-off-by: Kate E. Reinecke <50168367+kreinecke@users.noreply.github.com>

cfdreddbot · 2019-09-18T14:27:11Z

✅ Hey kreinecke! The commit authors and yourself have already signed the CLA.

codecov · 2019-09-18T15:12:30Z

Codecov Report

Merging #3882 into v2-master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           v2-master    #3882   +/-   ##
==========================================
  Coverage      52.21%   52.21%           
==========================================
  Files            785      785           
  Lines          23017    23017           
  Branches        4124     4124           
==========================================
  Hits           12019    12019           
  Misses         10998    10998

Signed-off-by: Kate E. Reinecke <50168367+kreinecke@users.noreply.github.com>

…efactor

KlapTrap · 2019-09-30T09:06:23Z

@nwmac Did you review this?

nwmac

A couple of comments

nwmac · 2019-10-15T12:51:54Z

src/jetstream/plugins/cloudfoundryhosting/main.go

@@ -126,6 +126,10 @@ func (ch *CFHosting) Init() error {

 		//Force auth endpoint type to remote (CF UAA)
 		ch.portalProxy.GetConfig().ConsoleConfig.AuthEndpointType = "remote"
+		err := ch.portalProxy.InitStratosAuthService(interfaces.Remote)


Do we need to do the init here? Its done in main.go.

We override the type to remote - so won't the init in main.go do the right thing?

If so, we can remove InitStratosAuthService from the interface we expose to plugins

nwmac · 2019-10-15T12:52:18Z

src/jetstream/repository/interfaces/portal_proxy.go

 	GetEndpointTypeSpec(typeName string) (EndpointPlugin, error)

 	// Auth
+	InitStratosAuthService(t AuthEndpointType) error


Would be good not to expose this to plugins.

…osting plugin

linux-foundation-easycla · 2019-10-16T17:16:22Z

The committers are authorized under a signed CLA.

✅ Kate Reinecke (a131b2d, 9a10910, dfacbac, f5ffacb, d44287c, 4010f7b, b2ccad4, 206acd4, 57eda90, 56263d7, d8bcb03, f8a85a5, 3df620d, f4fefd7, ba731b4, 3754439, bf4c587, e459a2f)
✅ Neil MacDougall (7687d35, 1cf3edd, e37baa9, 318f35c, 8b56c79, bfb0591, c064a2c)
✅ Richard Cox (423ba10, 8baa937, 4c24d26)

…ctor

codecov-io · 2019-10-30T17:12:36Z

Codecov Report

Merging #3882 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3882   +/-   ##
=======================================
  Coverage   61.12%   61.12%           
=======================================
  Files         860      860           
  Lines       29359    29359           
  Branches     4294     4294           
=======================================
  Hits        17945    17945           
  Misses      11414    11414

…ctor

* master: Add clean routes to e2e-clean-remnants (#4007) Auth jetstream refactor (#3882) Remove page nav not needed Local user account docs (#3952) Fix go mod files (#3986) Update references following graduation Ensure build cache upload fail does not fail job (#3994) Fixes issue properly Preparation for 2.6.0 Release Fix alignment of user button on newer Firefox Fix cert gen on Mac OSX 10.15

* master: (38 commits) CC fixes When viewing enpoint events, provide an endpoint only events view. Change error time period to 30 minutes Fixed exception Minor endpoint page changes Update events page slightly Fix app summay page warning for autoscaler check Fix unit tests Tidy up Finish wiring in of notification bar to errors, fix issue with multiple triggered events for same config Only show bell when there's notifications (whether read or unread) Allow notifications to be marked as 'read' - read notifications will not be shown in the alarm bell count WIP Add clean routes to e2e-clean-remnants (#4007) Tie in error state to notifications Allow notifications to be marked as 'read' - read notifications will not be shown in the alarm bell count Fix unit tests Fix exception on endpoint errors Linting Auth jetstream refactor (#3882) ...

kreinecke added 10 commits September 18, 2019 13:46

Sketch out minimal login/logout refactor implementation

a131b2d

Signed-off-by: Kate E. Reinecke <50168367+kreinecke@users.noreply.github.com>

1st version of auth refactor building and unit tests pass

9a10910

Signed-off-by: Kate E. Reinecke <50168367+kreinecke@users.noreply.github.com>

Finish sketching out minimal login/logout refactor implementation

dfacbac

Signed-off-by: Kate E. Reinecke <50168367+kreinecke@users.noreply.github.com>

1st version of auth refactor working

f5ffacb

More imprvements to auth refactor

d44287c

Signed-off-by: Kate E. Reinecke <50168367+kreinecke@users.noreply.github.com>

Refactor complete docs started

4010f7b

Signed-off-by: Kate E. Reinecke <50168367+kreinecke@users.noreply.github.com>

UAA Auth documented and complete

b2ccad4

Signed-off-by: Kate E. Reinecke <50168367+kreinecke@users.noreply.github.com>

Local Auth documented and complete

206acd4

Signed-off-by: Kate E. Reinecke <50168367+kreinecke@users.noreply.github.com>

Transfer some portalProxy fields to localAuth and uaaAuth structs

57eda90

Signed-off-by: Kate E. Reinecke <50168367+kreinecke@users.noreply.github.com>

Complete Login Auth refactor. Tidy up echo routing - create session a…

56263d7

…nd login auth groups Signed-off-by: Kate E. Reinecke <50168367+kreinecke@users.noreply.github.com>

kreinecke added 2 commits September 18, 2019 16:21

Codeclimate fixes

d8bcb03

Signed-off-by: Kate E. Reinecke <50168367+kreinecke@users.noreply.github.com>

Fix codeclimate issue

f8a85a5

Signed-off-by: Kate E. Reinecke <50168367+kreinecke@users.noreply.github.com>

kreinecke added jetstream Backend related issues ready for review labels Sep 18, 2019

kreinecke self-assigned this Sep 18, 2019

kreinecke requested a review from nwmac September 19, 2019 08:00

kreinecke and others added 4 commits September 20, 2019 14:07

Don't log error when verifying session and session not found

3df620d

Signed-off-by: Kate E. Reinecke <50168367+kreinecke@users.noreply.github.com>

More appropriate log statement for login failure

f4fefd7

Signed-off-by: Kate E. Reinecke <50168367+kreinecke@users.noreply.github.com>

Merge remote-tracking branch 'origin/v2-master' into auth-jetstream-r…

7687d35

…efactor

Fix automatic merge issue

1cf3edd

kreinecke mentioned this pull request Sep 24, 2019

Local user auth - can not find user #3896

Open

nwmac reviewed Oct 15, 2019

View reviewed changes

Remove need for overriding auth type and initing auth service in CF h…

ba731b4

…osting plugin

kreinecke added 3 commits October 17, 2019 12:45

CF hosted remote user working

3754439

CF hosted local users working

bf4c587

Merge branch 'v2-master' into auth-jetstream-refactor

e459a2f

nwmac changed the base branch from v2-master to master October 29, 2019 15:06

nwmac added 2 commits October 30, 2019 08:48

Merge remote-tracking branch 'origin/master' into auth-jetstream-refa…

c064a2c

…ctor

Fix formatting of http error

7b7b506

nwmac added 3 commits October 31, 2019 10:24

Move back manifest file

abeaf78

Merge remote-tracking branch 'origin/master' into auth-jetstream-refa…

ee7b9e4

…ctor

Remove InitStratosAuthService from API

bb1bb1c

nwmac approved these changes Nov 1, 2019

View reviewed changes

nwmac merged commit ffc629e into master Nov 1, 2019

nwmac deleted the auth-jetstream-refactor branch November 1, 2019 20:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Auth jetstream refactor #3882

Auth jetstream refactor #3882

kreinecke commented Sep 18, 2019

cfdreddbot commented Sep 18, 2019

codecov bot commented Sep 18, 2019 •

edited

Loading

KlapTrap commented Sep 30, 2019

nwmac left a comment

nwmac Oct 15, 2019

nwmac Oct 15, 2019

linux-foundation-easycla bot commented Oct 16, 2019 •

edited

Loading

codecov-io commented Oct 30, 2019 •

edited

Loading

Auth jetstream refactor #3882

Auth jetstream refactor #3882

Conversation

kreinecke commented Sep 18, 2019

cfdreddbot commented Sep 18, 2019

codecov bot commented Sep 18, 2019 • edited Loading

Codecov Report

KlapTrap commented Sep 30, 2019

nwmac left a comment

Choose a reason for hiding this comment

nwmac Oct 15, 2019

Choose a reason for hiding this comment

nwmac Oct 15, 2019

Choose a reason for hiding this comment

linux-foundation-easycla bot commented Oct 16, 2019 • edited Loading

codecov-io commented Oct 30, 2019 • edited Loading

Codecov Report

codecov bot commented Sep 18, 2019 •

edited

Loading

linux-foundation-easycla bot commented Oct 16, 2019 •

edited

Loading

codecov-io commented Oct 30, 2019 •

edited

Loading