Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix connect endpoint issues in Firefox #3679

Merged
merged 3 commits into from
Jul 5, 2019
Merged

Fix connect endpoint issues in Firefox #3679

merged 3 commits into from
Jul 5, 2019

Conversation

nwmac
Copy link
Contributor

@nwmac nwmac commented Jun 21, 2019

  • subtext overlaps checkbox text
  • file upload does not work

@cfdreddbot
Copy link

✅ Hey nwmac! The commit authors and yourself have already signed the CLA.

@nwmac nwmac self-assigned this Jun 21, 2019
@codecov
Copy link

codecov bot commented Jun 21, 2019

Codecov Report

Merging #3679 into v2-master will decrease coverage by <.01%.
The diff coverage is 28.57%.

@@              Coverage Diff              @@
##           v2-master    #3679      +/-   ##
=============================================
- Coverage      51.43%   51.43%   -0.01%     
=============================================
  Files            725      726       +1     
  Lines          20567    20569       +2     
  Branches        3682     3682              
=============================================
+ Hits           10578    10579       +1     
- Misses          9989     9990       +1

@richard-cox richard-cox self-requested a review July 4, 2019 13:00
- use same fix as file input component
- fix folder order given differences between FF & Chrome
@richard-cox richard-cox merged commit 6617d31 into v2-master Jul 5, 2019
@richard-cox richard-cox deleted the firefox branch July 5, 2019 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants