Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

org/space quotas: listing and management #3650

Merged
merged 7 commits into from
Aug 13, 2019
Merged

org/space quotas: listing and management #3650

merged 7 commits into from
Aug 13, 2019

Conversation

vitoravelino
Copy link
Contributor

Quotas are now manageable and by that it means the user is now able to
list, add, edit and delete them.

Signed-off-by: Vítor Avelino vavelino@suse.com

Description

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Docs update
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have followed the guidelines in CONTRIBUTING.md, including the required formatting of the commit message

@vitoravelino vitoravelino requested a review from KlapTrap June 12, 2019 11:59
@cfdreddbot
Copy link

✅ Hey vitoravelino! The commit authors and yourself have already signed the CLA.

@richard-cox richard-cox changed the base branch from quota-details to v2-master July 18, 2019 12:22
richard-cox
richard-cox suggested changes Jul 18, 2019
View reviewed changes
Copy link
Contributor

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Think there's enough cross over between all the four versions of create/edit quota/space quota to use a single base component and override parts like populating existing values, submitting and text. This would remove a lot of duplicated code. There are a few other places this could happen as well, but lets just apply to this main big one.
  • Form fields should be updated with a checkbox to mark quota field as 'unlimited' (only where -1 is a valid value). When checked field should be disabled

...core/src/features/cloud-foundry/add-quota/create-quota-step/create-quota-step.component.html Outdated Show resolved Hide resolved
...es/cloud-foundry/edit-space-quota/edit-space-quota-step/edit-space-quota-step.component.html Outdated Show resolved Hide resolved
...core/src/features/cloud-foundry/add-quota/create-quota-step/create-quota-step.component.html Outdated Show resolved Hide resolved
...cloud-foundry-organization-space-quotas/cloud-foundry-organization-space-quotas.component.ts Outdated Show resolved Hide resolved
@vitoravelino vitoravelino changed the title [ignore] org/space quotas: listing and management [wip] org/space quotas: listing and management Jul 19, 2019
@vitoravelino vitoravelino changed the title [wip] org/space quotas: listing and management org/space quotas: listing and management Jul 19, 2019
@vitoravelino
org/space quotas: listing and management
f8e7ee0 
Quotas are now manageable and by that it means the user is now able to
list, add, edit and delete them.

Signed-off-by: Vítor Avelino <vavelino@suse.com>
@vitoravelino vitoravelino force-pushed the quotas-add-edit branch 5 times, most recently from 9a0c421 to dd04b52 Compare July 25, 2019 12:22
@vitoravelino vitoravelino force-pushed the quotas-add-edit branch 2 times, most recently from 005d1ef to 94071b1 Compare July 25, 2019 13:54
@codecov
Copy link

codecov bot commented Jul 25, 2019 •
edited
Loading

Codecov Report

Merging #3650 into v2-master will increase coverage by 0.3%.
The diff coverage is 66.8%.

@@             Coverage Diff              @@
##           v2-master    #3650     +/-   ##
============================================
+ Coverage      51.87%   52.17%   +0.3%     
============================================
  Files            765      783     +18     
  Lines          22425    22892    +467     
  Branches        4029     4088     +59     
============================================
+ Hits           11633    11945    +312     
- Misses         10792    10947    +155

created unlimited-input comp / refactored quota forms
2bbd025 
Signed-off-by: Vítor Avelino <vavelino@suse.com>
@richard-cox
Small tweaks
a4f40d5
@richard-cox
Tweaks
8e3f176 
- Show edit quota on org level quota details page
- Ensure we return from edit stepper from cf quota list, cf level quota page and org level quota page
- Apply permissions to edit quota
- Change org --> space in space level quota page
- Fix validation for sub 0 values
@richard-cox
Same Tweaks at space level
3c2ca17 
- Show edit quota on space level quota details page
- Ensure we return from edit stepper from org's space quota list, org level quota page and space level quota page
- Apply permissions to edit quota
@richard-cox richard-cox merged commit f35ebb6 into v2-master Aug 13, 2019
@richard-cox richard-cox deleted the quotas-add-edit branch August 13, 2019 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richard-cox richard-cox richard-cox approved these changes

@KlapTrap KlapTrap Awaiting requested review from KlapTrap

Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vitoravelino @cfdreddbot @richard-cox