Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get default stack from the Stacks API #3648

Merged
merged 3 commits into from
Jun 13, 2019
Merged

Get default stack from the Stacks API #3648

merged 3 commits into from
Jun 13, 2019

Conversation

nwmac
Copy link
Contributor

@nwmac nwmac commented Jun 10, 2019

No description provided.

@cfdreddbot
Copy link

✅ Hey nwmac! The commit authors and yourself have already signed the CLA.

@codecov
Copy link

codecov bot commented Jun 10, 2019

Codecov Report

Merging #3648 into v2-master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           v2-master    #3648   +/-   ##
==========================================
  Coverage      51.42%   51.42%           
==========================================
  Files            725      725           
  Lines          20567    20567           
  Branches        3682     3682           
==========================================
  Hits           10577    10577           
  Misses          9990     9990

@nwmac nwmac requested a review from richard-cox June 11, 2019 08:22
@nwmac nwmac self-assigned this Jun 11, 2019
Copy link
Contributor

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can merge once gates pass

@richard-cox richard-cox merged commit 4438b33 into v2-master Jun 13, 2019
@richard-cox richard-cox deleted the stack-config branch June 13, 2019 15:16
KlapTrap added a commit that referenced this pull request Jun 19, 2019
* entity-catalogue-store: (57 commits)
  Fix jasmine exception in build
  Fixes following merge
  cf: moved entity factory schemas to its module (#3657)
  Address todo - use common getCFEntityKey For example from EntityCatalogueHelpers.buildEntityKey(organizationSchemaKey, CF_ENDPOINT_TYPE) to getCFEntityKey(organizationSchemaKey)
  Add general todo's following review with Nathan
  Indentation fixes (will make reviewing later much easier) also includes import fixes
  Fix edit org/space (to allow testing of merge)
  Fix navigate from org summary to org spaces
  Fixes following merge
  Remove unused users.effetct.ts (#3660)
  Invite user e2e tests (#3382)
  Support separate auth and token endpoints for the console (#3635)
  Add e2e uaa helpers, use to create/delete user for remove roles tests (#3651)
  Allow appVersion in helm chart to be set to a product version (#3637)
  Get default stack from the Stacks API (#3648)
  Helm Chart: Add imagelist to the helm chart (#3638)
  E2E Tests: Update cleanup script to remove test users (#3644)
  Remove ZenHub (#3652)
  Disable top level remove user tests to unblock pr's (#3646)
  Show header in none dashboard pages
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants