Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve failed connection message for cf & metrics endpoints #3600

Merged
merged 1 commit into from
Jun 5, 2019
Merged

Improve failed connection message for cf & metrics endpoints #3600

merged 1 commit into from
Jun 5, 2019

Conversation

richard-cox
Copy link
Contributor

  • previously we showed the same message regardless of type of failure
  • now we show a better message for bad credentials failures
    • cf - we show the specific error message (for instance 'Bad Credentials')
    • metrics - we show 'unauthorised' for 401's

@richard-cox
Improve failed connection message for cf & metrics endpoints
0fff8f7 
- previously we showed the same message regardless of type of failure
- now we show a better message for bad credentials failures
  - cf - we show the specific error message (for instance 'Bad Credentials')
  - metrics - we show 'unauthorised' for 401's
@richard-cox richard-cox self-assigned this May 20, 2019
@cfdreddbot
Copy link

✅ Hey richard-cox! The commit authors and yourself have already signed the CLA.

@codecov
Copy link

codecov bot commented May 20, 2019

Codecov Report

Merging #3600 into v2-master will decrease coverage by <.01%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           v2-master    #3600      +/-   ##
=============================================
- Coverage      51.84%   51.84%   -0.01%     
=============================================
  Files            720      720              
  Lines          20226    20226              
  Branches        3613     3613              
=============================================
- Hits           10487    10486       -1     
- Misses          9739     9740       +1

nwmac
nwmac approved these changes Jun 5, 2019
View reviewed changes
Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit 2cedcc5 into v2-master Jun 5, 2019
@nwmac nwmac deleted the improve-connect-error branch June 5, 2019 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwmac nwmac nwmac approved these changes

Assignees

@richard-cox richard-cox

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@richard-cox @cfdreddbot @nwmac