Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle endpoint types that do no support connect #3596

Merged
merged 1 commit into from
Jun 5, 2019

Conversation

richard-cox
Copy link
Contributor

- Also add space between failed register message and details
@cfdreddbot
Copy link

✅ Hey richard-cox! The commit authors and yourself have already signed the CLA.

@codecov
Copy link

codecov bot commented May 16, 2019

Codecov Report

Merging #3596 into v2-master will increase coverage by <.01%.
The diff coverage is 60%.

@@              Coverage Diff              @@
##           v2-master    #3596      +/-   ##
=============================================
+ Coverage      51.84%   51.85%   +<.01%     
=============================================
  Files            720      720              
  Lines          20226    20234       +8     
  Branches        3613     3615       +2     
=============================================
+ Hits           10486    10492       +6     
- Misses          9740     9742       +2

Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit f610905 into v2-master Jun 5, 2019
@nwmac nwmac deleted the handle-no-connect-endpoints branch June 5, 2019 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle 'no auth' auth type in optional connect step
3 participants