Differentiate Disconnected Endpoint Cards #3591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disconnected and checking status. Card opacity restored on hover. (#3554). Update endpoint card no-link SCSS class definition to BEM syntax. Signed-off-by: Kate E. Reinecke <50168367+kreinecke@users.noreply.github.com>
|
✅ Hey kreinecke! The commit authors and yourself have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #3591 +/- ##
=============================================
- Coverage 51.83% 51.42% -0.42%
=============================================
Files 720 724 +4
Lines 20224 20563 +339
Branches 3613 3681 +68
=============================================
+ Hits 10484 10574 +90
- Misses 9740 9989 +249 |
richard-cox
previously requested changes
May 21, 2019
To fix that, we're going to make a change to ensure that we're going to make the change to ensure non-connectable endpoints are treated as connected endpoints on the FE once the helm work is merged in. See #3647 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add NgClass directive to reduce endpoint card opacity when disconnected and checking status. Card opacity restored on hover. (#3554). Update endpoint card no-link SCSS class definition
to BEM syntax.
Signed-off-by: Kate E. Reinecke 50168367+kreinecke@users.noreply.github.com
fixes #3554