Don't show cell metrics when they're not available #3586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Handle case where metrics is available for the cf however the `firehose_value_metric_rep_unhealthy_cell` metric is not - So.. - don't show the cell column in the app instances table - show an appropriate message in the cf cells page (as requested we don't hide the tab)
|
✅ Hey richard-cox! The commit authors and yourself have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #3586 +/- ##
=============================================
- Coverage 51.83% 51.74% -0.09%
=============================================
Files 720 720
Lines 20221 20237 +16
Branches 3612 3615 +3
=============================================
- Hits 10481 10472 -9
- Misses 9740 9765 +25 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
firehose_value_metric_rep_unhealthy_cellmetric is not