cf/spaces routes: fixed breadcrumbs path for apps #3572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When user were navigating to apps through cf/spaces mapped routes, the breadcrumbs was losing context from the previous path. Now it preserves the previous path context. Signed-off-by: Vítor Avelino <vavelino@suse.com>
|
✅ Hey vitoravelino! The commit authors and yourself have already signed the CLA. |
|
I've tested and reviewed this, it's all good. I'm just waiting for the e2e tests to run. |
|
@KlapTrap all good to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When user were navigating to apps through cf/spaces mapped routes, the
breadcrumbs was losing context from the previous path. Now it preserves
the previous path context.
Signed-off-by: Vítor Avelino vavelino@suse.com
How Has This Been Tested?
Manually.
Types of changes