-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
marketplace: cf endpoint on card when multiple cf connected #3560
Conversation
✅ Hey vitoravelino! The commit authors and yourself have already signed the CLA. |
571dc55
to
e82b75c
Compare
@vitoravelino can you take a look at the FE unit tests. Thanks! |
e82b75c
to
76e2952
Compare
ad28da5
to
d071097
Compare
Fixed. |
Codecov Report
@@ Coverage Diff @@
## v2-master #3560 +/- ##
=============================================
+ Coverage 51.83% 51.83% +<.01%
=============================================
Files 720 720
Lines 20221 20224 +3
Branches 3612 3613 +1
=============================================
+ Hits 10481 10484 +3
Misses 9740 9740 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor point about import sorting, otherwise LGTM
@@ -5,45 +5,40 @@ import { TabNavService } from '../../../../../tab-nav.service'; | |||
import { BaseTestModulesNoShared } from '../../../../../test-framework/cloud-foundry-endpoint-service.helper'; | |||
import { ServicesService } from '../../../../features/service-catalog/services.service'; | |||
import { ServicesServiceMock } from '../../../../features/service-catalog/services.service.mock'; | |||
import { AppNameUniqueDirective } from '../../../app-name-unique.directive/app-name-unique.directive'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sorting of these imports seems different to the one's I'm seeing. Do you use vs code, and if so do you use the TypeScript Hero plugin or have any custom rules? We've probably got something wrong in our docs here either way so would be good to get to the bottom of
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed the imports and re-added them automatically. That's probably why it got messy like that unless there's a specific configuration for the typescript hero extension.
When multiple CF were connected the user could end up with multiple services with the same name without being able to identify the source of that. Now when multiple CF endpoints are connected a CF endpoint is shown on each service card so the user can identify where it comes from. Signed-off-by: Vítor Avelino <vavelino@suse.com>
d071097
to
c9e8ff6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, once passed gates this is good to merge
When multiple CF were connected the user could end up with multiple services
with the same name without being able to identify the source of that.
Now when multiple CF endpoints are connected a CF endpoint is shown on
each service card so the user can identify where it comes from.
Signed-off-by: Vítor Avelino vavelino@suse.com
How Has This Been Tested?
Types of changes
Screenshot
Fixes #3026