Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

organization/space: added created and updated dates to summary #3460

Merged
merged 1 commit into from
Apr 5, 2019

Conversation

vitoravelino
Copy link
Contributor

Besides adding those info there was a slightly change in the data
display itself. Instead of a single list of attributes we splitted
that into two columns in order to utilize better the white space.

Signed-off-by: Vítor Avelino vavelino@suse.com

Fixes #3452

Screenshot-20190327103957-865x238
Screenshot-20190327104045-862x239

@cfdreddbot
Copy link

✅ Hey vitoravelino! The commit authors and yourself have already signed the CLA.

@vitoravelino vitoravelino force-pushed the organization-spaces-dates branch from 456e27c to 5401a5b Compare March 27, 2019 13:56
@vitoravelino
Copy link
Contributor Author

vitoravelino commented Mar 27, 2019

I've seen a few usages of the app-metadata and app-metadata__two-cols around, so maybe it's time to extract those into <app-metadata> and <app-metadata-col>? What do you think?

@vitoravelino vitoravelino force-pushed the organization-spaces-dates branch from 5401a5b to 596ac45 Compare March 27, 2019 14:33
@codecov
Copy link

codecov bot commented Mar 27, 2019

Codecov Report

Merging #3460 into v2-master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           v2-master    #3460   +/-   ##
==========================================
  Coverage      51.44%   51.44%           
==========================================
  Files            697      697           
  Lines          19418    19418           
  Branches        3428     3428           
==========================================
  Hits            9989     9989           
  Misses          9429     9429

Copy link
Contributor

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a few minor comments regarding tests. I think you're right about the duplicated classes being an issue, however for this PR I think we're fine without any other changes.

Besides adding those info there was a slightly change in the data
display itself. Instead of a single list of attributes we splitted
that into two columns in order to utilize better the white space.

Signed-off-by: Vítor Avelino <vavelino@suse.com>
Copy link
Contributor

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll prod it until it gets through the gates.

@richard-cox richard-cox merged commit 7fb9216 into v2-master Apr 5, 2019
@richard-cox richard-cox deleted the organization-spaces-dates branch April 5, 2019 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants