-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
organization/space: added created and updated dates to summary #3460
Conversation
✅ Hey vitoravelino! The commit authors and yourself have already signed the CLA. |
456e27c
to
5401a5b
Compare
I've seen a few usages of the |
5401a5b
to
596ac45
Compare
Codecov Report
@@ Coverage Diff @@
## v2-master #3460 +/- ##
==========================================
Coverage 51.44% 51.44%
==========================================
Files 697 697
Lines 19418 19418
Branches 3428 3428
==========================================
Hits 9989 9989
Misses 9429 9429 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a few minor comments regarding tests. I think you're right about the duplicated classes being an issue, however for this PR I think we're fine without any other changes.
.../shared/components/cards/card-cf-org-user-details/card-cf-org-user-details.component.spec.ts
Outdated
Show resolved
Hide resolved
...re/src/shared/components/cards/card-cf-space-details/card-cf-space-details.component.spec.ts
Outdated
Show resolved
Hide resolved
Besides adding those info there was a slightly change in the data display itself. Instead of a single list of attributes we splitted that into two columns in order to utilize better the white space. Signed-off-by: Vítor Avelino <vavelino@suse.com>
596ac45
to
89c932c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I'll prod it until it gets through the gates.
Besides adding those info there was a slightly change in the data
display itself. Instead of a single list of attributes we splitted
that into two columns in order to utilize better the white space.
Signed-off-by: Vítor Avelino vavelino@suse.com
Fixes #3452