Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation change #3449

Closed
wants to merge 38 commits into from
Closed

Navigation change #3449

wants to merge 38 commits into from

Conversation

nwmac
Copy link
Contributor

@nwmac nwmac commented Mar 25, 2019

Side nav changes with persistent icon bar on left-hand side

KlapTrap and others added 26 commits December 13, 2018 12:07
* v2-master:
  Fix test failure on faster system
  Remove empty rule
  Address review feedback
  Delete secrets.yaml.sys
  Fix e2e tests
  Tidy up a tad
  WIP
  Resolve conflicts. Fit in with customization
  Hide app vars tab if user is not a space developer
  Lint fix & column rename
  Show app chip list for space routes list bound apps - As per space service instance list - Contributes to #2610
  Update side-nave logo with light version
* v2-master: (27 commits)
  Update status_updates.md
  Unit test fixes
  Added focus to first steps, ensure forms are common width
  Removed second entity.entity.entity check
  Fix weird search/replace issue
  Merge upstream changes properly
  Fix cancel on redeploy, removed some more github specific naming
  Fix & optimise e2e test
  Address PR Feedback
  wip
  General improvements - Fixed appFocus directive - Set focus of confirm dialog to cancel instead of confirm - Add/Edit App name - Add more space between async name taken check spinner and input field - Tidied up imports - Removed unused `AppEventDetailDialogComponentComponent`. Looks like a bad merge remnent - Fixed `newNonnAngularInterval` typo
  Ensure we don't try to get length of undefined endpoint description
  Remove global manage apps link - also removed the now defunct select users first step
  Fix e2e test
  Fix e2e test
  E2E Fix
  Fix e2e tests
  Fix e2e tests for GitLab changes
  Unit test fixes
  Fix unit tests
  ...
* v2-master: (415 commits)
  CC Fix
  CC Fixed and copy change
  Update fetch all users max pagination
  Merge fixes
  Minor text change
  Small text change
  Minor change to the invite table header
  Update invite users text
  Update the docs guide
  Update docs
  Fix unit test
  Fix imports
  Publish release pipeline fix (#3404)
  Re-instate setup mode
  Weekly update
  Ensure we don't add invalid state when reseting pagination
  Add create-many-users script
  Automated test script improvements and fixes (#3402)
  Fixed date --> data typo
  Remove TODOs for now
  ...
* v2-master: (130 commits)
  docs update
  Fix unit test
  Fix issues from review - Ensure extensions/extension-types.ts remains free from other imports - Now check endpoint detail type is correct at runtime - Cf Endpoint Type is now registered in cf package - Ensure cf package tests & lint execute correctly - Ensure endpoint details components are destroyed correctly
  Fix merge issue
  Fix merge issue
  More info
  Fix lint issues
  Add note
  Fix missing .entity
  Priorities & tweaks
  Remove index.html file
  Add support for endpoint sub type (and metadata) (#3423)
  Fix service broker action - Ensure that the guid property is properly set - This means error handling happens correcty
  Update cf-api-v3.md
  Updaes
  Another lint fix
  Fix linting, don't show image if no image
  Disable endpoint card routerLink using new directive
  Missing images
  Fix existing getIconButton bug - There may be other places where this magically worked and now correctly won't
  ...
@cfdreddbot
Copy link

✅ Hey nwmac! The commit authors and yourself have already signed the CLA.

@nwmac nwmac self-assigned this Mar 25, 2019
Copy link
Contributor

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • + Create shown on org & space pages isn't aligned (+ is lower than text)
  • Blue bar action icons need moving into the Summary pages on
    • Cloud Foundry Summary
    • Cloud Foundry Org Summary
    • Cloud Foundry Space Summary
    • Cloud Foundry Service Summary
  • App Variables screen length Issue
  • App Pages - Metrics tab needs icon

@richard-cox richard-cox added needs attention This PR needs attention and removed in review labels Mar 25, 2019
@KlapTrap KlapTrap self-requested a review April 2, 2019 16:10
@KlapTrap KlapTrap self-assigned this Apr 2, 2019
@KlapTrap KlapTrap changed the base branch from v2-master to tabs-layout-change April 9, 2019 10:30
@KlapTrap KlapTrap changed the base branch from tabs-layout-change to v2-master April 9, 2019 10:36
Copy link
Contributor

@KlapTrap KlapTrap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% sold on the auto expanding sidenav, it seems to get in the way quite often. What are we trying to solve/avoid with the change and is there any other way to fix it?

@@ -1 +1,77 @@
@mixin dashboard-page-theme($theme, $app-theme) {}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theme files should be kept for theming related style only. We shouldn't be using them to get around angular's component styling.

@richard-cox
Copy link
Contributor

Closing given changes in #3494 and SUSE#154

@nwmac nwmac deleted the navigation-change branch June 12, 2019 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants