Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for slide-in side help and write in to endpoint connect dialog #3433

Merged
merged 11 commits into from
Apr 8, 2019
Merged

Add support for slide-in side help and write in to endpoint connect dialog #3433

merged 11 commits into from
Apr 8, 2019

Conversation

nwmac
Copy link
Contributor

@nwmac nwmac commented Mar 15, 2019

No description provided.

@nwmac nwmac self-assigned this Mar 15, 2019
@cfdreddbot
Copy link

✅ Hey nwmac! The commit authors and yourself have already signed the CLA.

@codecov
Copy link

codecov bot commented Mar 15, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (v2-master@ead1146). Click here to learn what that means.
The diff coverage is 28.12%.

@@             Coverage Diff              @@
##             v2-master    #3433   +/-   ##
============================================
  Coverage             ?   25.97%           
============================================
  Files                ?      685           
  Lines                ?    18799           
  Branches             ?     3272           
============================================
  Hits                 ?     4883           
  Misses               ?    13916           
  Partials             ?        0

richard-cox
richard-cox suggested changes Mar 19, 2019
View reviewed changes
Copy link
Contributor

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor thought, will this work when the user is in a stepper?

src/frontend/packages/core/src/shared/components/markdown-preview/markdown-preview.component.ts Outdated Show resolved Hide resolved
src/frontend/packages/core/src/shared/components/markdown-preview/markdown-preview.component.ts Outdated Show resolved Hide resolved
src/frontend/packages/core/src/shared/components/markdown-preview/markdown-preview.component.ts Outdated Show resolved Hide resolved
src/frontend/packages/core/src/shared/components/markdown-preview/markdown-preview.component.ts Outdated Show resolved Hide resolved
@richard-cox richard-cox added the needs attention This PR needs attention label Apr 2, 2019
@richard-cox richard-cox removed the needs attention This PR needs attention label Apr 8, 2019
@richard-cox richard-cox merged commit 6893838 into v2-master Apr 8, 2019
@richard-cox richard-cox deleted the side-help branch April 8, 2019 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richard-cox richard-cox richard-cox approved these changes

Assignees

@nwmac nwmac

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nwmac @cfdreddbot @richard-cox