Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix service broker action #3427

Merged
merged 1 commit into from
Mar 11, 2019
Merged

Fix service broker action #3427

merged 1 commit into from
Mar 11, 2019

Conversation

richard-cox
Copy link
Contributor

  • Ensure that the guid property is properly set
  • This means error handling happens correctly

- Ensure that the guid property is properly set
- This means error handling happens correcty
@cfdreddbot
Copy link

✅ Hey richard-cox! The commit authors and yourself have already signed the CLA.

@codecov
Copy link

codecov bot commented Mar 11, 2019

Codecov Report

Merging #3427 into v2-master will increase coverage by <.01%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           v2-master    #3427      +/-   ##
=============================================
+ Coverage      70.31%   70.32%   +<.01%     
=============================================
  Files            694      694              
  Lines          30760    30760              
  Branches        6997     6997              
=============================================
+ Hits           21629    21631       +2     
+ Misses          9131     9129       -2

Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@nwmac nwmac merged commit df3dff7 into v2-master Mar 11, 2019
@richard-cox richard-cox deleted the fix-service-broker-action branch March 14, 2019 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants