Add card view to endpoint list #3422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
richard-cox
commented
Mar 5, 2019
richard-cox
commented
- depends on Fix exception thrown on home page #3420
- Add card view to the endpoints list, including endpoint type icon
- Move endpoint specific fields, like cf username and admin bool, into custom 'details' step
|
✅ Hey richard-cox! The commit authors and yourself have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #3422 +/- ##
==============================================
- Coverage 51.69% 25.95% -25.75%
==============================================
Files 678 682 +4
Lines 18620 18711 +91
Branches 3242 3258 +16
==============================================
- Hits 9626 4856 -4770
- Misses 8994 13855 +4861 |
- There may be other places where this magically worked and now correctly won't
nwmac
suggested changes
Mar 13, 2019
| @@ -2,6 +2,9 @@ import { Type } from '@angular/core'; | |||
| import { FormGroup } from '@angular/forms'; | |||
| import { Schema, schema } from 'normalizr'; | |||
|
|
|||
| import { EndpointModel } from '../../../../store/src/types/endpoint.types'; | |||
| import { TableCellCustom } from '../../shared/components/list/list.types'; | |||
There was a problem hiding this comment.
The intent with the extensions folder/package was that it should not import anything else in the Stratos code base - thus it could be a separate package and extensions would only need to import the extensions package - they would not need to import anything else.
Is there a way to loosen the typing on listDetailsComponent and check it at runtime for compatibility?
| if (!this.cell) { | ||
| const componentFactory = this.componentFactoryResolver.resolveComponentFactory(e.listDetailsComponent); | ||
| const componentRef = this.target.createComponent(componentFactory); | ||
| this.cell = componentRef.instance as TableCellCustom<EndpointModel>; |
There was a problem hiding this comment.
I think you need a destroy function to clear this custom component up when this component is destroyed.
- Ensure extensions/extension-types.ts remains free from other imports - Now check endpoint detail type is correct at runtime - Cf Endpoint Type is now registered in cf package - Ensure cf package tests & lint execute correctly - Ensure endpoint details components are destroyed correctly
richard-cox
force-pushed
the
endpoint-list-cards
branch
from
650988a to
0b457fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.