Hide favorites when using SQLite #3419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Hey nwmac! The commit authors and yourself have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #3419 +/- ##
============================================
+ Coverage 51.44% 51.54% +0.1%
============================================
Files 697 699 +2
Lines 19418 19444 +26
Branches 3428 3437 +9
============================================
+ Hits 9989 10022 +33
+ Misses 9429 9422 -7 |
richard-cox
suggested changes
Mar 1, 2019
There was a problem hiding this comment.
Two minor UXy things, both when stratos is pushed to cf & using SQLlite
- After log in the nav bar blips (shrinks and grows)
- Minor, after log in or nav'ing direct to
/homethe back button fails (due to auto forward)- If there's an easy way to remove it from the history we should try, or I think shift the redirect into a route gate as per
AuthGuardService
- If there's an easy way to remove it from the history we should try, or I think shift the redirect into a route gate as per
nwmac
added
comments-addressed
and removed
needs attention
- happened everywhere, except most cases ux is too quick too see
- most visually prominent when pushed to cf
- on log in, with home disabled, there's a redirect which ends up firing
`this.router.events` in dashboard-base.componet. this closed the side nav
under certain conditionsm. unfortunatly these conditions included a stale
default that we later changed ('over'-->'side') which led to us flip flopping
the side nav from open to close and back to open
- fix is to start on the desired state
- tested with wide and thin browser
richard-cox
approved these changes
Apr 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.