Fixes double requests when single cf connected for lists with cf filter #3313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Specific refresh indicator based on click of refresh button - New e2e test for non-local space routes list - Prep for e2e loading/refresh indicator tests
|
✅ Hey richard-cox! The commit authors and yourself have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #3313 +/- ##
============================================
- Coverage 70.97% 70.48% -0.5%
============================================
Files 661 661
Lines 29173 29182 +9
Branches 6665 6663 -2
============================================
- Hits 20706 20569 -137
- Misses 8467 8613 +146 |
richard-cox
force-pushed
the
fix-list-loading-indicators
branch
from
e408066 to
2c31a24
Compare
KlapTrap
changed the title
|
I'm happy with this so I'll merge it once the gates pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loading indicator fixes are now in #3363.