Validate entity names locally #3296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
richard-cox
commented
Jan 2, 2019
richard-cox
commented
- validate length of entity names during create process
- service instances, route host and route path
- app, org and space seem to handle long names fine
- fixes Service instance names should be limited to 50 chars #3262
- service instances, route host and route path - app, org and space seem to handle long names fine
|
✅ Hey richard-cox! The commit authors and yourself have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #3296 +/- ##
=============================================
- Coverage 70.77% 70.75% -0.02%
=============================================
Files 642 644 +2
Lines 28358 28474 +116
Branches 6447 6461 +14
=============================================
+ Hits 20071 20148 +77
- Misses 8287 8326 +39 |
KlapTrap
suggested changes
Jan 4, 2019
KlapTrap
added
needs attention
|
@KlapTrap I thought about that, but as the change would not be visible the user would end up with an outcome they weren't expecting. The other alternative would be to fire the validation on change rather than defocus |
richard-cox
added
ready for review
and removed
needs attention
|
I'm happy with either. |
- template form failed to do this properly, converted to reactive - there's some odd code in here, it also fails when creating tcp routes (unrelated) - this whole step should be replaced with the create route stepper when merged into deploy
|
@KlapTrap Cool, I've made it so the form shows validation errors on enter |
richard-cox
added
needs attention
richard-cox
added
ready for review
and removed
needs attention
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.