Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploying Stratos as a CF App using docker image #3294

Merged
merged 3 commits into from
Jan 10, 2019
Merged

Deploying Stratos as a CF App using docker image #3294

merged 3 commits into from
Jan 10, 2019

Conversation

kinjelom
Copy link
Contributor

Description

Some information how to deploy Stratos as a CF App using docker image

Motivation and Context

This is really the simplest way.

How Has This Been Tested?

It was tested manually by me.

Types of changes

  • Docs update

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have followed the guidelines in CONTRIBUTING.md, including the required formatting of the commit message

@cfdreddbot
Copy link

✅ Hey wildloop! The commit authors and yourself have already signed the CLA.

@codecov
Copy link

codecov bot commented Dec 27, 2018 •
edited
Loading

Codecov Report

Merging #3294 into v2-master will increase coverage by 0.14%.
The diff coverage is 70.01%.

@@              Coverage Diff              @@
##           v2-master    #3294      +/-   ##
=============================================
+ Coverage      70.89%   71.03%   +0.14%     
=============================================
  Files            641      651      +10     
  Lines          28167    28647     +480     
  Branches        6405     6521     +116     
=============================================
+ Hits           19968    20349     +381     
- Misses          8199     8298      +99

@KlapTrap KlapTrap added ready for review community Community Raised Issue labels Dec 31, 2018
richard-cox
richard-cox suggested changes Jan 7, 2019
View reviewed changes
Copy link
Contributor

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After discussing this with the team, given that docker by default is not available to all, I think we'd be happier keeping the original cf push instructions first and then have docker instructions second

deploy/cloud-foundry/README.md Outdated Show resolved Hide resolved
deploy/cloud-foundry/README.md Outdated Show resolved Hide resolved
deploy/cloud-foundry/README.md Outdated Show resolved Hide resolved
@richard-cox richard-cox added needs attention This PR needs attention and removed ready for review labels Jan 7, 2019
@richard-cox richard-cox mentioned this pull request Jan 8, 2019
Closed
@richard-cox
Copy link
Contributor

@wildloop Thanks for making the updates! I've created #3307 to track the stable docker image requirement. We'll be doing a release within a week or so, I think at that point we'll create it.

@richard-cox richard-cox added blocked and removed needs attention This PR needs attention labels Jan 8, 2019
@richard-cox richard-cox merged commit 35dfafb into cloudfoundry:v2-master Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richard-cox richard-cox richard-cox approved these changes

Assignees
No one assigned
Labels
blocked community Community Raised Issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kinjelom @cfdreddbot @richard-cox @KlapTrap