Ensure we don't try to get length of undefined endpoint description #3274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Hey KlapTrap! The commit authors and yourself have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #3274 +/- ##
=============================================
+ Coverage 71.01% 71.01% +<.01%
=============================================
Files 639 639
Lines 28029 28029
Branches 6387 6388 +1
=============================================
+ Hits 19904 19905 +1
+ Misses 8125 8124 -1 |
richard-cox
approved these changes
Dec 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an CF endpoint is unreachable, viewing the CF summary page causes a "Cannot get length of undefined" exception. This is because we're trying to get the length of the endpoint description that doesn't exist.
Improved the code and made it more resilient.