List Multifilter Improvements #3270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
richard-cox
commented
Dec 7, 2018
richard-cox
commented
- If the first filter has only one item, automatically select it and hide the drop down
- Remove the filter loading indicator
- Fixes Only show the endpoint filter when there's more than one registered #3079
- If the first filter has only one item, automatically select it and hide the drop down - Remove the filter loading indicator
|
✅ Hey richard-cox! The commit authors and yourself have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #3270 +/- ##
=============================================
+ Coverage 70.88% 70.93% +0.05%
=============================================
Files 641 641
Lines 28167 28194 +27
Branches 6405 6409 +4
=============================================
+ Hits 19966 20000 +34
+ Misses 8201 8194 -7 |
* v2-master: (33 commits) Update status_updates.md Unit test fixes Added focus to first steps, ensure forms are common width Removed second entity.entity.entity check Fix weird search/replace issue Merge upstream changes properly Fix cancel on redeploy, removed some more github specific naming Fix & optimise e2e test Address PR Feedback wip General improvements - Fixed appFocus directive - Set focus of confirm dialog to cancel instead of confirm - Add/Edit App name - Add more space between async name taken check spinner and input field - Tidied up imports - Removed unused `AppEventDetailDialogComponentComponent`. Looks like a bad merge remnent - Fixed `newNonnAngularInterval` typo Remove empty rule Address review feedback Ensure we don't try to get length of undefined endpoint description Delete secrets.yaml.sys Remove global manage apps link - also removed the now defunct select users first step Resolve conflicts. Fit in with customization Fix e2e test Fix e2e test E2E Fix ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.