Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to dashboard in service instance table #3267

Merged
merged 2 commits into from
Dec 12, 2018
Merged

Conversation

richard-cox
Copy link
Contributor

- Adds link to table, we already show in card
- Adds functionalty to basic table cell to show link as a `view` style link
@cfdreddbot
Copy link

✅ Hey richard-cox! The commit authors and yourself have already signed the CLA.

@codecov
Copy link

codecov bot commented Dec 6, 2018

Codecov Report

Merging #3267 into v2-master will decrease coverage by 0.03%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##           v2-master   #3267      +/-   ##
============================================
- Coverage      71.04%     71%   -0.04%     
============================================
  Files            636     636              
  Lines          27945   27951       +6     
  Branches        6361    6362       +1     
============================================
- Hits           19853   19848       -5     
- Misses          8092    8103      +11

Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit 3732dee into v2-master Dec 12, 2018
@nwmac nwmac deleted the show-dashboard-url branch December 12, 2018 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display service instance dashboard urls in service instances table view
3 participants