Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Org and Space status bar to Org/Space Cards #3265

Merged
merged 12 commits into from
Jan 10, 2019
Merged

Add Org and Space status bar to Org/Space Cards #3265

merged 12 commits into from
Jan 10, 2019

Conversation

richard-cox
Copy link
Contributor

  • Depends on Show refresh button for latest modified application lists #3213
  • Cards show only nothing or amber
  • Amber is shown when any quota is near or at limit
  • There's going to be some changes once we handle scaling routes/service instances/domains etc (we currently require these inline.. which will change in the future)

@richard-cox richard-cox self-assigned this Dec 6, 2018
@cfdreddbot
Copy link

✅ Hey richard-cox! The commit authors and yourself have already signed the CLA.

@codecov
Copy link

codecov bot commented Jan 9, 2019 •
edited
Loading

Codecov Report

Merging #3265 into v2-master will decrease coverage by 0.02%.
The diff coverage is 67.92%.

@@              Coverage Diff              @@
##           v2-master    #3265      +/-   ##
=============================================
- Coverage      70.87%   70.85%   -0.03%     
=============================================
  Files            653      657       +4     
  Lines          28942    29083     +141     
  Branches        6574     6618      +44     
=============================================
+ Hits           20514    20607      +93     
- Misses          8428     8476      +48

@nwmac nwmac removed the blocked-pr label Jan 9, 2019
@nwmac nwmac changed the base branch from v2-master to 2.0.0-base January 9, 2019 12:55
@nwmac nwmac changed the base branch from 2.0.0-base to v2-master January 9, 2019 12:55
nwmac
nwmac approved these changes Jan 10, 2019
View reviewed changes
Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit fe147ba into v2-master Jan 10, 2019
@nwmac nwmac deleted the org-space-card-status branch January 10, 2019 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwmac nwmac nwmac approved these changes

Assignees

@richard-cox richard-cox

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@richard-cox @cfdreddbot @nwmac