Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add confirmation dialog to Restage app #3263

Merged
merged 2 commits into from
Dec 7, 2018
Merged

Add confirmation dialog to Restage app #3263

merged 2 commits into from
Dec 7, 2018

Conversation

richard-cox
Copy link
Contributor

@richard-cox richard-cox commented Dec 5, 2018 •
edited
Loading

fixes #3024

@richard-cox richard-cox self-assigned this Dec 5, 2018
@cfdreddbot
Copy link

✅ Hey richard-cox! The commit authors and yourself have already signed the CLA.

@codecov
Copy link

codecov bot commented Dec 5, 2018 •
edited
Loading

Codecov Report

Merging #3263 into v2-master will decrease coverage by <.01%.
The diff coverage is 52.38%.

@@              Coverage Diff              @@
##           v2-master    #3263      +/-   ##
=============================================
- Coverage      71.04%   71.03%   -0.01%     
=============================================
  Files            634      634              
  Lines          27827    27832       +5     
  Branches        6336     6336              
=============================================
+ Hits           19769    19771       +2     
- Misses          8058     8061       +3

nwmac
nwmac approved these changes Dec 7, 2018
View reviewed changes
Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit 905d709 into v2-master Dec 7, 2018
@nwmac nwmac deleted the confirm-restage branch December 7, 2018 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwmac nwmac nwmac approved these changes

Assignees

@richard-cox richard-cox

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-stage App Action: Needs confirmation model
3 participants
@richard-cox @cfdreddbot @nwmac