Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add user has roles filter to users tables #3258

Merged
merged 4 commits into from
Dec 12, 2018
Merged

Add user has roles filter to users tables #3258

merged 4 commits into from
Dec 12, 2018

Conversation

richard-cox
Copy link
Contributor

  • Show a drop down filter on CF/Org/Space Users table
  • Filter changes users shown in one of three ways
    • Show all users
    • [Default] Show users with roles .. with respect to context (at org level only show users with roles in that org and not other orgs, etc)
    • Show users with no roles... again with respect to context
  • Does not include the users table shown in the manage user steppers (to be removed in subsequent PR)
  • Fixes Make reviewing org/space roles usable #3075

@richard-cox richard-cox self-assigned this Dec 4, 2018
@cfdreddbot
Copy link

✅ Hey richard-cox! The commit authors and yourself have already signed the CLA.

@richard-cox richard-cox mentioned this pull request Dec 4, 2018
Merged
@codecov
Copy link

codecov bot commented Dec 4, 2018

Codecov Report

Merging #3258 into v2-master will decrease coverage by 0.05%.
The diff coverage is 67.17%.

@@              Coverage Diff              @@
##           v2-master    #3258      +/-   ##
=============================================
- Coverage      71.04%   70.98%   -0.06%     
=============================================
  Files            633      634       +1     
  Lines          27802    27823      +21     
  Branches        6330     6336       +6     
=============================================
  Hits           19751    19751              
- Misses          8051     8072      +21

nwmac
nwmac approved these changes Dec 12, 2018
View reviewed changes
Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit dae5a90 into v2-master Dec 12, 2018
@nwmac nwmac deleted the user-list-filter branch December 12, 2018 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwmac nwmac nwmac approved these changes

Assignees

@richard-cox richard-cox

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@richard-cox @cfdreddbot @nwmac