Make the table multi actions more obvious #3251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Hey KlapTrap! The commit authors and yourself have already signed the CLA. |
|
None selected Some selected Moved the multi actions to the left and removed the "n selected" text. It should be move obvious that the icons are actions that affect the selected entities. |
|
@mogul I've done a quick change to make the multi actions more obvious, what do you think? |
Codecov Report
@@ Coverage Diff @@
## v2-master #3251 +/- ##
=============================================
- Coverage 70.92% 70.86% -0.06%
=============================================
Files 642 641 -1
Lines 28199 28167 -32
Branches 6412 6405 -7
=============================================
- Hits 19999 19960 -39
- Misses 8200 8207 +7 |
|
As a quick fix, it'll help! |
richard-cox
suggested changes
Dec 17, 2018
KlapTrap
added
ready for review
and removed
needs attention
richard-cox
approved these changes
Jan 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3250