Hide app vars tab if user is not a space developer #3247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Hey nwmac! The commit authors and yourself have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #3247 +/- ##
=============================================
- Coverage 71.04% 71.01% -0.03%
=============================================
Files 634 639 +5
Lines 27827 28029 +202
Branches 6336 6387 +51
=============================================
+ Hits 19769 19906 +137
- Misses 8058 8123 +65 |
richard-cox
suggested changes
Dec 6, 2018
secrets.yaml.sys
Outdated
| @@ -0,0 +1,57 @@ | |||
| # E2E Configuration file | |||
There was a problem hiding this comment.
Should this file be in the PR?
| @@ -213,6 +215,15 @@ export class ApplicationService { | |||
| this.appEnvVars = this.appEnvVarsService.createEnvVarsObs(this.appGuid, this.cfGuid); | |||
| } | |||
|
|
|||
| public getApplicationEnvVarsMonitor() { | |||
There was a problem hiding this comment.
This is better placed in ApplicationEnvVarsHelper alongside createEnvVarsObs
| @@ -110,9 +111,28 @@ export class ApplicationTabsBaseComponent implements OnInit, OnDestroy { | |||
| } | |||
| }); | |||
|
|
|||
| // Listen for the response to the env vars API call - if it errors then we hide the variables tab | |||
| // This is simpler than the code to check permissions since we make the env vars request anyway | |||
| const appDoesNotHaveEnvVars$ = this.applicationService.getApplicationEnvVarsMonitor().entityRequest$.pipe( | |||
There was a problem hiding this comment.
Think we should stick to the permissions. That way the user can then refresh the list and still see the env vars. To switch would need to
- Add new
ENV_VARS_VIEWentry to theCurrentUserPermissionsenum in current-user-ermissions.config.ts - Add entry for new enum value to
permissionConfigsin the same file (which just needs to be look for space dev) - In
application-tabs-base.component.tsimportCurrentUserPermissionsServiceand use it'scanfunction with something likecan(<new env vars view enum>, <endppoint guid>, <space giud>)
richard-cox
approved these changes
Dec 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2725