Limit card titles to two-lines with ellipsis/fade out #3241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Hey nwmac! The commit authors and yourself have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #3241 +/- ##
=============================================
+ Coverage 71.04% 71.05% +0.01%
=============================================
Files 633 634 +1
Lines 27802 27816 +14
Branches 6330 6335 +5
=============================================
+ Hits 19751 19765 +14
Misses 8051 8051 |
…ubator/stratos into fix-text-label-overflow
richard-cox
approved these changes
Dec 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2340
Updates card titles to be a maximum of 2 lines high.
For webkit browsers (Chrome, Safari and also supported by Edge) we use the webkit multiline clamp CSS.
For firefox where this is not supported, we fade the end of the 2nd line out to indicate that it is truncated.