App Deploy: Add Public GitLab Repository support #3239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Hey nwmac! The commit authors and yourself have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #3239 +/- ##
============================================
- Coverage 71.01% 70.91% -0.1%
============================================
Files 639 642 +3
Lines 28029 28199 +170
Branches 6387 6411 +24
============================================
+ Hits 19904 19998 +94
- Misses 8125 8201 +76 |
richard-cox
suggested changes
Dec 4, 2018
There was a problem hiding this comment.
- redeploy a git project throws error on step 1.
Looks like the CheckProjectExists contains a null scm property
ERROR TypeError: Cannot read property 'getRepository' of null at SwitchMapSubscriber.project (deploy-app.effects.ts:61) - clicking on a link to a commit should take user to
gitlab.com/<repo>/commit/<commit>, as per github - low priority
- select github, enter
richard-cox/cf-quick-appfor project, click next - see list of commits
- click back
- select gitlab, enter
richard-cox/cf-quick-appfor project, click next - list of commits has not changed
.. - this only seems to be a problem for repos with same name. could be something like we're using the same pagination key
- select github, enter
| import { inject, TestBed } from '@angular/core/testing'; | ||
| import { CommonModule } from '@angular/common'; | ||
| import { CoreModule } from '../../../core/core.module'; | ||
| import { SharedModule } from '../../../shared/shared.module'; | ||
| import { createBasicStoreModule } from '../../../test-framework/store-test-helper'; | ||
| import { AppState } from '../../../store/app-state'; | ||
| import { GitSCMService } from '../../../shared/data-services/scm/scm.service'; | ||
| import { GithubProjectExistsDirective } from './github-project-exists.directive'; | ||
| import { GITHUB_API_URL, getGitHubAPIURL } from '../../../core/github.helpers'; | ||
|
|
||
|
|
||
| describe('GithubProjectExistsDirective', () => { |
There was a problem hiding this comment.
Looks like from here down Github hasn't been updated to GitSCM
|
I've pushed a commit with some minor changes, also noticed the deployment info icon for gitlab appears well to the right, think this might be a merge issue. Will have a look on monday |
richard-cox
approved these changes
Dec 17, 2018
|
Icon issue was fixed after restarting local dev server |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.