Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stricter check for jetstream error object #3223

Merged
merged 2 commits into from
Nov 21, 2018
Merged

Add stricter check for jetstream error object #3223

merged 2 commits into from
Nov 21, 2018

Conversation

richard-cox
Copy link
Contributor

  • Previously we just looked for an 'error' property
  • This caused issues for the autoscaler team
  • We now have a stricter check

@richard-cox richard-cox added ready for review community Community Raised Issue labels Nov 20, 2018
@richard-cox richard-cox self-assigned this Nov 20, 2018
@cfdreddbot
Copy link

✅ Hey richard-cox! The commit authors and yourself have already signed the CLA.

@codecov
Copy link

codecov bot commented Nov 20, 2018 •
edited
Loading

Codecov Report

Merging #3223 into v2-master will decrease coverage by 0.03%.
The diff coverage is 18.18%.

@@              Coverage Diff              @@
##           v2-master    #3223      +/-   ##
=============================================
- Coverage      71.09%   71.06%   -0.04%     
=============================================
  Files            632      633       +1     
  Lines          27752    27760       +8     
  Branches        6314     6318       +4     
=============================================
- Hits           19731    19728       -3     
- Misses          8021     8032      +11

nwmac
nwmac approved these changes Nov 21, 2018
View reviewed changes
Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit 7cb2a25 into v2-master Nov 21, 2018
@nwmac nwmac deleted the fix-handling-no-cf-response branch November 21, 2018 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwmac nwmac nwmac approved these changes

Assignees

@richard-cox richard-cox

Labels
community Community Raised Issue ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@richard-cox @cfdreddbot @nwmac