Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show refresh button for latest modified application lists #3213

Merged
merged 9 commits into from
Jan 9, 2019
Merged

Show refresh button for latest modified application lists #3213

merged 9 commits into from
Jan 9, 2019

Conversation

richard-cox
Copy link
Contributor

blocked on #3212

@richard-cox richard-cox self-assigned this Nov 19, 2018
@cfdreddbot
Copy link

✅ Hey richard-cox! The commit authors and yourself have already signed the CLA.

@codecov
Copy link

codecov bot commented Nov 19, 2018 •
edited
Loading

Codecov Report

Merging #3213 into v2-master will decrease coverage by <.01%.
The diff coverage is 77.44%.

@@              Coverage Diff              @@
##           v2-master    #3213      +/-   ##
=============================================
- Coverage      70.87%   70.87%   -0.01%     
=============================================
  Files            653      653              
  Lines          28862    28948      +86     
  Branches        6564     6576      +12     
=============================================
+ Hits           20457    20516      +59     
- Misses          8405     8432      +27

@KlapTrap KlapTrap added needs attention This PR needs attention and removed ready for review labels Nov 20, 2018
@KlapTrap KlapTrap self-requested a review November 20, 2018 16:03
KlapTrap
KlapTrap suggested changes Nov 20, 2018
View reviewed changes
Copy link
Contributor

@KlapTrap KlapTrap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code climate issues need to be fixed. FE unit tests also failed so I'm re-running them.

@richard-cox richard-cox added ready for review and removed needs attention This PR needs attention labels Nov 21, 2018
@richard-cox richard-cox mentioned this pull request Dec 6, 2018
Merged
@KlapTrap KlapTrap added conflicts Merge conflicts on PR and removed ready for review labels Dec 31, 2018
@KlapTrap
Copy link
Contributor

E2E tests failing so I'm re-running them.

@richard-cox richard-cox added ready for review and removed conflicts Merge conflicts on PR labels Jan 3, 2019
@nwmac nwmac removed the blocked-pr label Jan 9, 2019
@nwmac nwmac changed the base branch from v2-master to add-metrics January 9, 2019 12:48
@nwmac nwmac changed the base branch from add-metrics to v2-master January 9, 2019 12:48
nwmac
nwmac approved these changes Jan 9, 2019
View reviewed changes
Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit eee461e into v2-master Jan 9, 2019
@nwmac nwmac deleted the refresh-latest-apps branch January 9, 2019 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KlapTrap KlapTrap KlapTrap requested changes

@nwmac nwmac nwmac approved these changes

Assignees

@richard-cox richard-cox

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@richard-cox @cfdreddbot @KlapTrap @nwmac