Only show + icon when we have at least one connected CF #3211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Hey nwmac! The commit authors and yourself have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #3211 +/- ##
============================================
+ Coverage 71.09% 71.1% +<.01%
============================================
Files 632 632
Lines 27752 27753 +1
Branches 6314 6315 +1
============================================
+ Hits 19731 19734 +3
+ Misses 8021 8019 -2 |
KlapTrap
suggested changes
Nov 20, 2018
|
|
||
| this.haveConnectedCf$ = cloudFoundryService.cFEndpoints$.pipe( | ||
| map(endpoints => endpoints.map(endpoint => endpoint.connectionStatus === 'connected')), | ||
| map(connected => connected.reduce((a, v) => a || v, false)) |
There was a problem hiding this comment.
Something like !!connected.find(isConnected => isConnected) would be more efficient.
There was a problem hiding this comment.
Or even just !!endpoints.find(endpoint => endpoint.connectionStatus === 'connected'))
There was a problem hiding this comment.
Yeah - I just used what we had in the CF page - but can have a look at simplifying
KlapTrap
approved these changes
Nov 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2714