Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space service tidy up #3197

Merged
merged 2 commits into from
Nov 14, 2018
Merged

Space service tidy up #3197

merged 2 commits into from
Nov 14, 2018

Conversation

KlapTrap
Copy link
Contributor

@KlapTrap KlapTrap commented Nov 12, 2018

Add prod high mem npm target
Remove duplicate get all services for space action GetServicesForSpace
Remove undeeded lines
Remove invalid sorting in space apps table (its non-local and cannot use sort by name & instances)

See #3172

…rSpace`

- Remove undeeded lines
- Remove invalid sorting in space apps table (its non-local and cannot use sort by name & instances)
@cfdreddbot
Copy link

✅ Hey KlapTrap! The commit authors and yourself have already signed the CLA.

@KlapTrap KlapTrap changed the title Service space tidy Space service tidy up Nov 12, 2018
@codecov
Copy link

codecov bot commented Nov 12, 2018

Codecov Report

Merging #3197 into v2-master will increase coverage by 0.03%.
The diff coverage is 75%.

@@              Coverage Diff              @@
##           v2-master    #3197      +/-   ##
=============================================
+ Coverage      71.05%   71.09%   +0.03%     
=============================================
  Files            632      632              
  Lines          27781    27752      -29     
  Branches        6317     6314       -3     
=============================================
- Hits           19741    19731      -10     
+ Misses          8040     8021      -19

@KlapTrap KlapTrap merged commit b2347fb into v2-master Nov 14, 2018
@nwmac nwmac deleted the service-space-tidy branch June 12, 2019 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants