Show table of cell health state changes instead of chart #3135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Table shows changes to cell health
- To test more populated table make the following change to `src/frontend/app/shared/components/list/list-types/cf-cell-health/cf-cell-health-source.ts`
const values = response[0].data.result[0].values;
to
const values = response[0].data.result[0].values.map(value => {
const timestamp = value['0'];
return [
timestamp,
timestamp * 1000 % 2 === 0 ? '1' : '0'
];
});
|
Hey richard-cox! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #3135 +/- ##
=============================================
+ Coverage 46.31% 71.11% +24.8%
=============================================
Files 630 632 +2
Lines 27580 27683 +103
Branches 6271 6297 +26
=============================================
+ Hits 12773 19687 +6914
+ Misses 14807 7996 -6811 |
KlapTrap
suggested changes
Oct 31, 2018
|
I'm a little un-easy about having If we decided to create a separate component for #3162 then we should ensure we should remove the |
KlapTrap
approved these changes
Oct 31, 2018
|
I'm happy to merge this once the gate has passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes Improve Cell Health visual #3127
Table shows changes to cell health
To test more populated table make the following change to
src/frontend/app/shared/components/list/list-types/cf-cell-health/cf-cell-health-source.tsto